-
Notifications
You must be signed in to change notification settings - Fork 41
fix: resolve various compiler warnings #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixed multiple compiler warnings across the codebase including: 1. Removed unused variable 'byte_count' in DBackingStoreProxy 2. Added [[maybe_unused]] attribute to unused functions getInputRectangleY and atomName 3. Removed Q_DECL_HIDDEN from several class declarations 4. Fixed initialization order in DXcbXSettingsPrivate constructor 5. Removed negative check for function pointer offset in VtableHook 6. Added override keyword to test class methods 7. Added Q_UNUSED for unused parameters in various functions 8. Fixed potential integer comparison issues in DWaylandInterfaceHook 9. Added proper type casting for window property comparison 10. Fixed Qt version conditional compilation in DPlatformBackingStoreHelper These changes improve code quality by: - Removing dead code - Making unused function intentions explicit - Following modern C++ practices - Ensuring proper initialization order - Preventing potential integer comparison issues - Maintaining cross-version Qt compatibility Influence: 1. Verify wallpaper sharing functionality still works 2. Test input handling in text fields 3. Validate platform settings behavior 4. Check XSettings integration 5. Test vtable hooking functionality 6. Verify unit tests still pass 7. Test wayland window splitting functionality 8. Validate high DPI scaling behavior fix: 修复各种编译器警告 修复了代码库中的多个编译器警告,包括: 1. 移除DBackingStoreProxy中未使用的变量'byte_count' 2. 为未使用的函数getInputRectangleY和atomName添加[[maybe_unused]]属性 3. 从多个类声明中移除Q_DECL_HIDDEN 4. 修复DXcbXSettingsPrivate构造函数中的初始化顺序 5. 移除VtableHook中对函数指针偏移量的负值检查 6. 为测试类方法添加override关键字 7. 为多个未使用的参数添加Q_UNUSED 8. 修复DWaylandInterfaceHook中潜在的整数比较问题 9. 为窗口属性比较添加适当的类型转换 10. 修复DPlatformBackingStoreHelper中的Qt版本条件编译 这些改进通过以下方式提升代码质量: - 移除无用代码 - 明确未使用函数的意图 - 遵循现代C++实践 - 确保正确的初始化顺序 - 防止潜在的整数比较问题 - 保持跨Qt版本的兼容性 Influence: 1. 验证壁纸共享功能是否仍然正常工作 2. 测试文本字段中的输入处理 3. 验证平台设置行为 4. 检查XSettings集成 5. 测试vtable钩子功能 6. 验证单元测试是否仍然通过 7. 测试wayland窗口分割功能 8. 验证高DPI缩放行为
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Synchronize source files from linuxdeepin/qt5platform-plugins. Source-pull-request: linuxdeepin/qt5platform-plugins#300
deepin pr auto review根据提供的代码差异,我来分析一下代码的改进建议:
总体评价:
这些改动都是积极的,有助于提高代码质量和可维护性。建议继续保持这种代码审查和改进的实践。 |
Synchronize source files from linuxdeepin/qt5platform-plugins. Source-pull-request: linuxdeepin/qt5platform-plugins#300
Fixed multiple compiler warnings across the codebase including:
getInputRectangleY and atomName
DPlatformBackingStoreHelper
These changes improve code quality by:
Influence:
fix: 修复各种编译器警告
修复了代码库中的多个编译器警告,包括:
这些改进通过以下方式提升代码质量:
Influence: